Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External library is copied twice into the wheel #231

Open
delarosatrevin opened this issue Mar 23, 2020 · 1 comment
Open

External library is copied twice into the wheel #231

delarosatrevin opened this issue Mar 23, 2020 · 1 comment
Labels

Comments

@delarosatrevin
Copy link

I'm not sure if this problem is related to issue #136.

I have been struggling to create a wheel for my package that has the following structure:

_emcore.so (python extension, install also some binaries) -> depends on ->
libemcore.so (using cmake, installed as "external library once" and install some binaries)

When calling auditwheel repair, it seems that the copylib function is called twice somehow for libemcore.so, so it creates two copies inside the wheel. One of the copies is later patched with other deps (e.g libtiff, libpng, etc) but the other not.

I have made a simple change that worked for me, checking if the soname was already in the dict before calling copylib. But I don't understand completely the whole process and I might be missing something. I also include the main change in PR #139 , but not sure if it helped in my case.

Please let me know if it can be useful that I create a PR with my changes.

delarosatrevin added a commit to delarosatrevin/auditwheel that referenced this issue Mar 23, 2020
@lkollar
Copy link
Contributor

lkollar commented Apr 17, 2020

Do you have a reproducer for this? It would be great if you PR had a test case for this.

@mayeut mayeut added the bug label Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants