Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditwheel repair should not fail on pure Python wheels #47

Closed
pombredanne opened this issue Aug 16, 2016 · 3 comments
Closed

auditwheel repair should not fail on pure Python wheels #47

pombredanne opened this issue Aug 16, 2016 · 3 comments

Comments

@pombredanne
Copy link

pombredanne commented Aug 16, 2016

... IMHO it should just do nothing in this case.
I experienced this while using the manylinux docker images on Travis here https://travis-ci.org/pombreda/thirdparty-manylinux/jobs/152792412#L697
The auditwheel step fails because a six wheels had been pulled in

@rmcgibbo
Copy link
Member

Yeah, it would be good to fix this. Pull requests welcome.

On Tue, Aug 16, 2016 at 4:36 PM, Philippe Ombredanne <
notifications@github.com> wrote:

... IMHO it should just do nothing in this case.
I experienced this while using the manylinux docker images on Pypi here
https://travis-ci.org/pombreda/thirdparty-manylinux/
The auditwheel step fails because a six wheels had been pulled in


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#47, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAnI_r_ZxfUR0YjjiosspKYJnWCrpiaRks5qgh9bgaJpZM4Jl0pz
.

-Robert

@ehashman
Copy link
Member

Looks like the wheel in question that failed was the six wheel.

We don't currently have any tests for auditwheel repair on pure wheels. Let's add one to tests/test_manylinux.py in order to close this issue.

@rdbisme
Copy link

rdbisme commented Jun 26, 2023

Hello, not sure if this is a regression, but repair command exits with 1 if a NonPlatformWheel is detected:

Is this normal? Or it's a regression?

(Quite annoying for me because I want to run the repair as a job in the CI, that can build pure python wheel or wheels with binary extensions and I'd love to avoid adding logic to avoid the pipeline to fail for former cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants