WIP for #115 : PEP8 refactor, CI to be added #116
Conversation
|
Travis build failing, something I can change in code? Please have a quick look and let me know. |
|
|
There was a problem hiding this comment.
No changes were made to the Travis tests that would cause linting to run in CI or tox, so we will need to include that.
It is difficult to debug the source of the problem because there are so many unrelated quote changes. Normally single quotes are used in individual strings so I'm not sure what linting profile you used that indicated this needed to change, and the way to do automated tests wasn't checked in so I can't reproduce.
I suggest that you revert the quote changes and that might make it easier to track down the problem?
| @@ -1,5 +1,5 @@ | |||
| import sys | |||
| from .main import main | |||
|
|
|||
| if __name__ == '__main__': | |||
| if __name__ == "__main__": | |||
There was a problem hiding this comment.
I'm not sure what docstyle you have applied but I don't want to switch from single quotes to double quotes.
There was a problem hiding this comment.
Sure I'll make the changes as you have said and place it in a day or two. thanks.
There was a problem hiding this comment.
I believe that was due to the use of the black formatter as per a suggestion in the conversation thread.
Nevertheless I will revert to as per your suggestion.
|
Closing this in favour of #124, didn't realize you opened a new PR. |
In addition to the pep8 formatting from flake8 errors/warnings,
certain mentions :
auditwheel/tools.py on Line No. 47
with open(glob(pjoin(out_dir, '*.dist-info/RECORD'))[0]) as f:The f is not needed.
Git message,
Reformatted python source as per PEP8
Modified all files referencing to pep8 guidelines
Used flake8 for audit.
Used black to format some files
The CI part using tox/travis is yet to be done
and will be taken ahead by maintainers.