Remove libcrypt.so.1 from library whitelist

[takluyver]

Following pypa/manylinux#305 : Fedora 30 no longer has libcrypt.so.1 (it has .2 instead), so IIUC it needs to be removed from the whitelist.

CC @njsmith .

[codecov]

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   87.64%   87.64%           
=======================================
  Files          19       19           
  Lines         963      963           
  Branches      210      210           
=======================================
  Hits          844      844           
  Misses         83       83           
  Partials       36       36

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b03e37...9e1a44d. Read the comment docs.

[codecov]

Codecov Report

Merging #182 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   87.64%   87.64%           
=======================================
  Files          19       19           
  Lines         963      963           
  Branches      210      210           
=======================================
  Hits          844      844           
  Misses         83       83           
  Partials       36       36

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b03e37...9e1a44d. Read the comment docs.

[njsmith]

This looks fine to me. The thing where there are multiple independent copies of the whitelist seems like it could probably be improved by some refactoring, but that's orthogonal....

Do we need to sort out the manylinux build images part before merging, or what's the plan there?

[takluyver]

I'm not sure. Presumably with this change but without changing the build images, wheels that use libcrypt would end up bundling the libcrypt.so.1 built from glibc. I don't have a good understanding of the possible consequences of that.

[takluyver]

The PRs for the manylinux images were merged, so as far as I know this can go in (& into a release) at any point now.