-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: replace unzip
usage with Python's zipfile
#324
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
+ Coverage 89.07% 89.35% +0.28%
==========================================
Files 23 23
Lines 1199 1203 +4
Branches 250 254 +4
==========================================
+ Hits 1068 1075 +7
+ Misses 82 78 -4
- Partials 49 50 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A question on the tests though: why not create the test zip fie in the test suite itself instead of checking the file in? That would make it clearer how the file is created and easier to maintain in case we have to change the input in the future.
|
||
|
||
def _write_test_permissions_zip(path): | ||
source_zip_xz = Path(__file__).parent / "test-permissions.zip.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file compressed twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the zip is 215kB, with xz compression, goes down to 8kB
I wanted a single source for that file without wondering if there was an implementation detail in python x.y that would make things flaky. |
I've approved the PR. If you still want to give this a go, we could handle it in a separate PR. |
This removes the need to have
unzip
installed.fixes #258
closes #312