Portability fixes when running on windows #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes:
- path handling in various places ('\' vs '/')
- newline when writing the new binary "script" shim
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
- Coverage 92.27% 92.26% -0.02%
==========================================
Files 20 20
Lines 1269 1267 -2
Branches 306 305 -1
==========================================
- Hits 1171 1169 -2
Misses 56 56
Partials 42 42 ☔ View full report in Codecov by Sentry. |
auvipy
approved these changes
Feb 7, 2024
|
Thanks @jvolkman Sorry not to have done this sooner. The time I have to work on auditwheel is pretty limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of repairwheel, auditwheel is vendored and can patch linux wheels from Windows. These are some of the more innocuous tweaks I've had to make to run successfully in a Windows environment.
Fixes: