chore: add some exception handling minor cleanup checks #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
Aug 22, 2023
| except Exception as exception: | ||
| raise BuildBackendException(exception, exc_info=sys.exc_info()) # noqa: B904 # use raise from | ||
| raise BuildBackendException(exception, exc_info=sys.exc_info()) from None |
There was a problem hiding this comment.
I think these were holdovers from Python 2 days. We are propagating the info anyway, so I think from None is correct here.
henryiii
force-pushed
the
henryiii/chore/exceptions
branch
2 times, most recently
from
d79f41d
to
fc5e4ce
Compare
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/exceptions
branch
from
fc5e4ce
to
fa1daf1
Compare
layday
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup based on Ruff checks.