Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid bug in various patch releases of Python #675

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Sep 6, 2023

Fix #674. Serious enough that we should get a patch release out imo.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@Secrus
Copy link
Member

Secrus commented Sep 6, 2023

Would be nice to get this merged and released, so package managers can use patched version :)

src/build/_util.py Outdated Show resolved Hide resolved
src/build/_util.py Outdated Show resolved Hide resolved
src/build/_util.py Outdated Show resolved Hide resolved
if (
(3, 8, 19) <= sys.version_info < (3, 9)
or (3, 9, 19) <= sys.version_info < (3, 10)
or (3, 10, 13) <= sys.version_info < (3, 11)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@layday
Copy link
Member

layday commented Sep 6, 2023

@encukou Sorry to bother you, but would you be able to please verify the above version numbers?

Co-authored-by: layday <layday@protonmail.com>
effigies added a commit to nipy/nibabel that referenced this pull request Sep 6, 2023
This reverts commit 3c94f8c.

This was not the correct way to specify a Python version, and I can't be
bothered to figure out the correct way, as this issue will be fixed in
build 1.0.1.

See bug report pypa/build#674
and fix pypa/build#675
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit 4b61b8e into pypa:main Sep 6, 2023
61 checks passed
@henryiii henryiii deleted the henryiii/fix/tarfilter branch September 6, 2023 16:01
@encukou
Copy link

encukou commented Sep 7, 2023

Confirmed. Thank you, and sorry for the trouble!

If another project wants to copy this approach: you could instead add and sys.version_info[:3] not in {(3, 8, 18), (3, 9, 18), (3, 10, 13), (3, 11, 5)}, (edit: see correction below) to allow builds of old Python with the feature backported.

@effigies
Copy link

effigies commented Sep 7, 2023

Thanks all!

@dimbleby
Copy link

If another project wants to copy this approach: you could instead add and sys.version_info[:3] not in {(3, 8, 18), (3, 9, 18), (3, 10, 13), (3, 11, 5)}, to allow builds of old Python with the feature backported.

per the changelogs, that set seems to be the versions at which the fix was made. The correct set of faulty versions should be {(3, 8, 17), (3, 9, 17), (3, 10, 12), (3, 11, 4)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building with Python 3.11.4 generates tarfile.LinkOutsideDestinationError
8 participants