-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid bug in various patch releases of Python #675
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Would be nice to get this merged and released, so package managers can use patched version :) |
if ( | ||
(3, 8, 19) <= sys.version_info < (3, 9) | ||
or (3, 9, 19) <= sys.version_info < (3, 10) | ||
or (3, 10, 13) <= sys.version_info < (3, 11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@encukou Sorry to bother you, but would you be able to please verify the above version numbers? |
Co-authored-by: layday <layday@protonmail.com>
This reverts commit 3c94f8c. This was not the correct way to specify a Python version, and I can't be bothered to figure out the correct way, as this issue will be fixed in build 1.0.1. See bug report pypa/build#674 and fix pypa/build#675
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Thank you, and sorry for the trouble! If another project wants to copy this approach: you could instead add |
Thanks all! |
per the changelogs, that set seems to be the versions at which the fix was made. The correct set of faulty versions should be |
Fix #674. Serious enough that we should get a patch release out imo.