Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manylinux builds failing with cibuildwheel 1.0.0 #208

Closed
msanders opened this issue Nov 12, 2019 · 5 comments
Closed

manylinux builds failing with cibuildwheel 1.0.0 #208

msanders opened this issue Nov 12, 2019 · 5 comments

Comments

@msanders
Copy link
Contributor

Seeing the following error after upgrading cibuildwheel from 0.10.2 to 1.0.0:

ERROR: running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/autopy
copying autopy/__init__.py -> build/lib/autopy
running build_ext
running build_rust
error: Can not find Rust compiler

Full stack trace: https://travis-ci.org/autopilot-rs/autopy/jobs/610426289
Commit (previous builds were passing): autopilot-rs/autopy@244e532

Only thing I found was this thread, so I tried removing sudo: required in travis.yml (which is currently just copy-pasted from the cibuildwheel README) but it had no effect. PyO3/setuptools-rust#54

@mayeut
Copy link
Member

mayeut commented Nov 12, 2019

I can see this in the log before the mentioned failure:

++ curl --proto =https --tlsv1.2 -sSf https://sh.rustup.rs -o /root/rust-installer/rustup.sh
317curl: option --proto: is unknown
318curl: try 'curl --help' or 'curl --manual' for more information
319++ sh /root/rust-installer/rustup.sh --default-toolchain=nightly-2019-10-05 -y
320/usr/bin/yum
321sh: /root/rust-installer/rustup.sh: No such file or directory

Manylinux images are now using manylinux2010 instead of manylinux1 images which might explain the difference in behavior. You can still use manylinux1 images using CIBW_MANYLINUX_X86_64_IMAGE, CIBW_MANYLINUX_I686_IMAGE options.

@joerick
Copy link
Contributor

joerick commented Nov 12, 2019

Agreed. Alternatively, at a guess, you could remove the --proto '=https' --tlsv1.2 from this command, since curl on the newer manylinux2010 images would be more up-to-date.

As a side note, I'd recommend adding set -o errexit to your build scripts - that'll help catch this sort of thing sooner.

@joerick joerick closed this as completed Nov 12, 2019
@msanders
Copy link
Contributor Author

It looks like this is due to this issue: rust-lang/rustup#1794. Removing the --proto flag from the curl command indeed fixed it.

Oddly, the version of curl on manylinux2010 was downgraded from 7.64.1 on manylinux1 to 7.19.7. Will be opening a separate issue upstream for that.

@mayeut
Copy link
Member

mayeut commented Nov 12, 2019

Oddly, the version of curl on manylinux2010 was downgraded from 7.64.1 on manylinux1 to 7.19.7. Will be opening a separate issue upstream for that.

@msanders,
"This is not a bug, this is a feature"

You can check pypa/manylinux#303 for more details. In a nutshell, CentOS 5 required curl/openssl to be rebuilt in order to connect to TLS 1.2 websites, CentOS 6 doesn't. To ease maintenance & security fixes, manylinux2010 now relies on CentOS to provide patches each time the image is rebuilt.

@msanders
Copy link
Contributor Author

Ah I see. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants