fix: specify full path to non-venv Python #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
mayeut
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
I do have local failures with test/test_macos_archs.py::test_universal2_testing_on_arm64[build] before this patch. Don't know why CI did not fail...
I'll keep draft #1880 opened to work on it this week-end in order to extend tests with uv.
I now see the same failure locally with this test so that means we were not testing tests with uv on other platforms.
mayeut
added a commit
to mayeut/cibuildwheel
that referenced
this pull request
Jun 13, 2024
This reverts commit 70fb1c4.
MusicalNinjaDad
pushed a commit
to MusicalNinjaDad/cibuildwheel
that referenced
this pull request
Jul 3, 2024
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1877. Should be fixed by astral-sh/uv#4289, but putting the correct path here is better anyway.