Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to shutil.move from Path.rename #389

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Switch back to shutil.move from Path.rename #389

merged 2 commits into from
Jun 25, 2020

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Jun 24, 2020

fix #388

YannickJadoul
YannickJadoul requested changes Jun 24, 2020
View reviewed changes
Copy link
Member

@YannickJadoul YannickJadoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's revert this fully to where we were before. If we use shutil.move, we can just give a directory, so the whole .name part to create a full path is not necessary.

Also, somehow mypy is happy with a Path as second argument, if I remember correctly.

cibuildwheel/macos.py Outdated Show resolved Hide resolved
@joerick joerick merged commit c88a73b into pypa:master Jun 25, 2020
@joerick
Copy link
Contributor

joerick commented Jun 25, 2020

Thanks for the speedy response @Czaki and @YannickJadoul . I'll cut a new release now.

@Czaki Czaki deleted the fix_shutil branch June 25, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannickJadoul YannickJadoul YannickJadoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSError: [WinError 17] The system cannot move the file to a different disk drive
3 participants
@Czaki @joerick @YannickJadoul