-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sysconfig to provide get_config_vars #111
Conversation
2fab875
to
53313b6
Compare
|
I initially wanted to only use get_config_vars from sysconfig and realized parse_makefile is almost exclusively used by get_config_vars.
I saw that If you prefer, I can revert the |
(note that I'm not the maintainer, I just had some questions 😉)
I don't see that here: https://github.com/python/cpython/blob/76dc047a0e88d10aad0405228d56e94438cdd91c/Lib/distutils/sysconfig.py#L77 |
I meant the one in sysconfig, https://github.com/python/cpython/blob/76dc047a0e88d10aad0405228d56e94438cdd91c/Lib/sysconfig.py#L266 |
I didn't realize cpython changed some stuff in python/cpython@90d02e5. I can port that commit over here. |
sysconfig != distutils.sysconfig
Wasn't that partly reverted again? -> python/cpython@fc98266ff627b |
I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks alright.
No description provided.