Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sysconfig to provide get_config_vars #111

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Jan 22, 2022

No description provided.

@isuruf isuruf force-pushed the sysconfig branch 3 times, most recently from 2fab875 to 53313b6 Compare January 22, 2022 19:05
@lazka
Copy link
Contributor

lazka commented Jan 23, 2022

  • Why are both changes in the same commit/PR?
  • What about existing users of distutils.sysconfig.parse_makefile?

@isuruf
Copy link
Contributor Author

isuruf commented Jan 23, 2022

Why are both changes in the same commit/PR?

I initially wanted to only use get_config_vars from sysconfig and realized parse_makefile is almost exclusively used by get_config_vars.

What about existing users of distutils.sysconfig.parse_makefile?

I saw that sysconfig.parse_makefile was changed to sysconfig._parse_makefile in cpython, so wanted to do the same.

If you prefer, I can revert the parse_makefile change.

@lazka
Copy link
Contributor

lazka commented Jan 23, 2022

(note that I'm not the maintainer, I just had some questions 😉)

What about existing users of distutils.sysconfig.parse_makefile?

I saw that sysconfig.parse_makefile was changed to sysconfig._parse_makefile in cpython, so wanted to do the same.

I don't see that here: https://github.com/python/cpython/blob/76dc047a0e88d10aad0405228d56e94438cdd91c/Lib/distutils/sysconfig.py#L77

@isuruf
Copy link
Contributor Author

isuruf commented Jan 23, 2022

@isuruf
Copy link
Contributor Author

isuruf commented Jan 23, 2022

I didn't realize cpython changed some stuff in python/cpython@90d02e5. I can port that commit over here.

@lazka
Copy link
Contributor

lazka commented Jan 23, 2022

I meant the one in sysconfig, https://github.com/python/cpython/blob/76dc047a0e88d10aad0405228d56e94438cdd91c/Lib/sysconfig.py#L266

sysconfig != distutils.sysconfig

I didn't realize cpython changed some stuff in python/cpython@90d02e5. I can port that commit over here.

Wasn't that partly reverted again? -> python/cpython@fc98266ff627b

@isuruf
Copy link
Contributor Author

isuruf commented Jan 25, 2022

I removed the parse_makefile change

Copy link
Member

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks alright.

@jaraco jaraco merged commit 64b9948 into pypa:main Jan 31, 2022
@isuruf isuruf deleted the sysconfig branch February 6, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants