Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through PROGRAMDATA, PROGRAMFILES env variables #127

Merged
merged 3 commits into from
Mar 19, 2022

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Mar 17, 2022

Fixes #118

@jaraco
Copy link
Member

jaraco commented Mar 19, 2022

I've been debating in my mind whether to go with the proposed approach or something like this instead:

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 6fca2f69f4..68f9944eca 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -9,6 +9,8 @@ concurrency:
 env:
   # pypa/distutils#99
   VIRTUALENV_NO_SETUPTOOLS: 1
+  # tox-dev/tox#2382
+  TOX_TESTENV_PASSENV: ProgramFiles ProgramFiles(x86) ProgramData
 
 jobs:
   test:

The nice thing about the proposed patch is that it would also apply to users testing distutils on Windows locally (outside CI). The nice thing about the CI config is that it applies broadly to all tox environments so is more applicable to all Github Actions, plus it happens on one line, so easier to document.

I don't intend either workaround to be around long term, so let's go with this one for now.

@jaraco jaraco merged commit 267dbd2 into pypa:main Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distutils.errors.DistutilsPlatformError: Unable to find vcvarsall.bat.
2 participants