Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flit_core: Normalize sdist names according to PEP 625 #628

Merged
merged 1 commit into from
May 6, 2023

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Feb 27, 2023

Normalize generated source distribution names using the same rules as wheels, as required by PEP 625 [1]. This aligns flit_core with other modern PEP 517 backends such as hatchling.

[1] https://peps.python.org/pep-0625/

Fixes #626

Normalize generated source distribution names using the same rules
as wheels, as required by PEP 625 [1].  This aligns flit_core with other
modern PEP 517 backends such as hatchling.

[1] https://peps.python.org/pep-0625/

Fixes pypa#626
@mgorny
Copy link
Contributor Author

mgorny commented Feb 27, 2023

I kinda suspect that it was too easy ;-).

@mgorny
Copy link
Contributor Author

mgorny commented Mar 18, 2023

@takluyver, ping.

@takluyver takluyver added this to the 3.9 milestone May 6, 2023
@takluyver takluyver added the bug label May 6, 2023
@takluyver
Copy link
Member

Thanks! I know what you mean that it seems too easy, but I can't see anything wrong, so 🤞 it's OK. Sorry it's taken me a while to look at it.

@takluyver takluyver merged commit d7c8cc0 into pypa:main May 6, 2023
@mgorny mgorny deleted the normalize-sdist branch May 7, 2023 04:34
@mgorny
Copy link
Contributor Author

mgorny commented May 7, 2023

Thanks! I suppose it's just that things are easy when software is well-written!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flit-core: Implement sdist name normalization (PEP 625)
2 participants