Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add support for uploading dists with metadata v2.4 #313

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

webknjaz
Copy link
Member

@webknjaz webknjaz commented Dec 6, 2024

This patch bumps the transitive package pkgutil to v1.12 to enable support for validating metadata v2.4 in Twine. It also integrates a Maturin-based package into the smoke test in CI as a regression check.

Closes #312
Resolves #311
Resolves #310

webknjaz and others added 3 commits December 6, 2024 19:35
This is necessary to allow the smoke test check uploading multiple
packages.
Signed-off-by: William Woodruff <william@trailofbits.com>
@webknjaz webknjaz added bug Something isn't working enhancement New feature or request labels Dec 6, 2024
@webknjaz webknjaz self-assigned this Dec 6, 2024
@webknjaz
Copy link
Member Author

webknjaz commented Dec 6, 2024

I've performed two pushes to demonstrate through the CI statuses that the smoke test fails with a Maturin dist at first but then is fixed post-bump.

@webknjaz webknjaz merged commit f371c3d into pypa:unstable/v1 Dec 6, 2024
5 checks passed
@ddelange
Copy link

ddelange commented Dec 6, 2024

this is awesome! many thanks @webknjaz

@diogomatsubara
Copy link

@webknjaz thanks a lot! Any chance of having a release this week that includes this fix?

@webknjaz
Copy link
Member Author

webknjaz commented Dec 9, 2024

@diogomatsubara on it! Right now, I'm in the process of double-checking the diff between the last tag and the top of unstable to decide what version number to use and what to include into the change log. Hold tight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidDistribution error for whl from pyo3/maturin 0.23.3
4 participants