Quote extras to guard shells with glob qualifiers #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sinoroc |
|
I've opened a similar PR over at |
matthewfeickert
force-pushed
the
feat/quote-extras-to-guard-aginst-globbing-shells
branch
from
ddc11d4
to
05b2c0d
Compare
sinoroc
approved these changes
Mar 6, 2023
matthewfeickert
force-pushed
the
feat/quote-extras-to-guard-aginst-globbing-shells
branch
from
05b2c0d
to
b9c377f
Compare
* Shells like zsh have glob qualifiers that will error if an extra is not quoted. While the glob qualifiers can be disabled, adding quotes guards against errors if people are copy-pasting or do not know that they can disable the behavior. * Use single quotes for Linux/Mac and use double quotes for Windows to follow existing style conventions.
matthewfeickert
force-pushed
the
feat/quote-extras-to-guard-aginst-globbing-shells
branch
from
b9c377f
to
294a131
Compare
|
This is ready for review, so gentle ping to @henryiii and @pradyunsg if they have time. |
henryiii
approved these changes
Mar 15, 2023
bhrutledge
approved these changes
Mar 15, 2023
matthewfeickert
deleted the
feat/quote-extras-to-guard-aginst-globbing-shells
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1209
Shells like
zshhave glob qualifiers that will error if an extra is not quoted. While the glob qualifiers can be disabled, adding quotes guards against errors if people are copy-pasting or do not know that they can disable the behavior.