Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted repo-review suggestions #820

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Assorted repo-review suggestions #820

wants to merge 2 commits into from
+1 −2

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos
Copy link
Contributor Author

I can add a repo-review pre-commit hook if you're interested: https://pypi.org/project/sp-repo-review/

@DimitriPapadopoulos
MyPy: show_error_codes deprecated
05b9587 
Must not have show_error_codes. It is now the default.
@DimitriPapadopoulos
ruff: show fixes if fixes enabled
59b861b 
If --fix is present, --show-fixes must be too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DimitriPapadopoulos @uranusjr @henryiii @brettcannon