Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many tests failing on Windows #757

Merged
merged 13 commits into from
Apr 9, 2024
Merged

Conversation

mathbou
Copy link
Contributor

@mathbou mathbou commented Apr 1, 2024

While testings for others PRs, I get a lot of permissionError. Windows does not like moving/replacing files if there aren't properly closed or another process is still on it.

I also get normalization problems on paths used in tests, so I enforced a posix format instead of a basic string cast.

@woodruffw
Copy link
Member

A few small nits; otherwise this is looking good! Thanks for your work here @mathbou!

mathbou and others added 3 commits April 4, 2024 19:28
Co-authored-by: William Woodruff <william@yossarian.net>
Co-authored-by: William Woodruff <william@yossarian.net>
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!

@mathbou would you mind adding a CHANGELOG entry as well? Something under "fixed" probably that matches the style of other entries 🙂

@woodruffw woodruffw added the needs-response Needs response from the reporter. label Apr 8, 2024
Signed-off-by: William Woodruff <william@trailofbits.com>
@woodruffw woodruffw enabled auto-merge (squash) April 9, 2024 19:52
@woodruffw woodruffw merged commit 231934b into pypa:main Apr 9, 2024
7 checks passed
@mathbou mathbou deleted the tests-failing-on-windows branch April 13, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-response Needs response from the reporter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants