-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip wheel should provide the name of the resulting file #6340
Comments
I'm on board for this. Will be happy to see a PR. |
Do you have a preference on how Pip should provide the info? Parseable line on stdout, option to record it in a file, or something else? |
(Sorry for the terseness) one-per-line, in a file specified via an optional flag. |
I see that this was done in #6377, but I'm kind of curious why we couldn't do something like this instead:
IMO this ends up being more robust compared to writing the filenames to a file, and avoids issues like:
|
I had previously resolved a similar use case with a similar approach as @chrahunt example in #6340 (comment). Recently I was looking at how poetry was handling VCS requirements. I wondered if it poetry could benefit from pip wheel outputting additional information on how it resolved such requirements. So maybe |
Following #7420, would you consider an alternative approach that lets It could start small (with the list of wheel names it produced), and would be extensible. It could include, for instance, information about direct URL references (e.g. how VCS references were resolved), and possibly in the future it could contain information about the result of the dependency resolution algorithm. |
What's the problem this feature will solve?
We want to adopt PEP 517 & 518 for Fedora, which uses separate
build
andinstall
phases. We want to run these commands (separately, and as automatically as possible):pip wheel
pip install <resulting wheel>
The problem is that while the PEP 517
build_wheel
hook returns the basename of the built wheel,pip
AFAIK doesn’t share this information any further. We simply don’t know where the built wheel is located.(Miro asked in packaging Discourse to see if this should go in the non-normative section of PEP 517. The response was that this would be a good feature request for
pip
, but that's it.)Describe the solution you'd like
Either:
Resulting wheel: foo-1.2.3-py2.py3-none-any.whl
, call this an API, and include tests to ensure it doesn't change.Alternative Solutions
Any other way to get the wheel name from pip would work.
We don't want to guess/construct it ourselves – we feel that should be pip's job to provide the complete name.
Additional
We're happy to provide the PR if y'all agree it would be an improvement.
The text was updated successfully, but these errors were encountered: