Fail legacy install if .egg-info directory was not created #6998

chrahunt · 2019-09-09T00:22:03Z

What's the problem this feature will solve?

Currently on the legacy install code path (here) if execution of setup.py install ... didn't result in an .egg-info directory being created we trace a warning and continue.

This is bad because we will have installed an uninstallable package and the only penalty is a small warning which is very easy to miss.

Describe the solution you'd like

Instead of tracing a warning we should throw an exception.

This prevents additional packages from being installed and possibly hiding the warning from users.

Alternative Solutions

Continue tracing the warning as before.

Additional context

this support query for this package which does an egg install in its setup.py regardless of setuptools version.
this query which implicates having an older version of setuptools

The text was updated successfully, but these errors were encountered:

pradyunsg · 2019-11-06T06:24:24Z

Cool, let's give this the regular 2-release deprecation -- if no one raises major concerns w.r.t. this, we'll start raising an error there. :)

* pypa/pip#6998 Do not assume egg install for all setuptools version

sbidoul · 2020-05-24T10:04:48Z

Added to milestone 20.2 (for removal)

pradyunsg · 2020-07-02T19:41:28Z

The relevant bit of code:

pip/src/pip/_internal/operations/install/legacy.py

Lines 109 to 124 in 0b23b77

    
           deprecated( 
        
               reason=( 
        
                   "{} did not indicate that it installed an " 
        
                   ".egg-info directory. Only setup.py projects " 
        
                   "generating .egg-info directories are supported." 
        
               ).format(req_description), 
        
               replacement=( 
        
                   "for maintainers: updating the setup.py of {0}. " 
        
                   "For users: contact the maintainers of {0} to let " 
        
                   "them know to update their setup.py.".format( 
        
                       req_name 
        
                   ) 
        
               ), 
        
               gone_in="20.2", 
        
               issue=6998, 
        
           )

153: Update pip to 20.2 r=duckinator a=pyup-bot This PR updates [pip](https://pypi.org/project/pip) from **20.1.1** to **20.2**. <details> <summary>Changelog</summary> ### 20.2 ``` ================= Deprecations and Removals ------------------------- - Deprecate setup.py-based builds that do not generate an ``.egg-info`` directory. (`6998 <https://github.com/pypa/pip/issues/6998>`_, `8617 <https://github.com/pypa/pip/issues/8617>`_) - Disallow passing install-location-related arguments in ``--install-options``. (`7309 <https://github.com/pypa/pip/issues/7309>`_) - Add deprecation warning for invalid requirements format "base>=1.0[extra]" (`8288 <https://github.com/pypa/pip/issues/8288>`_) - Deprecate legacy setup.py install when building a wheel failed for source distributions without pyproject.toml (`8368 <https://github.com/pypa/pip/issues/8368>`_) - Deprecate -b/--build/--build-dir/--build-directory. Its current behaviour is confusing and breaks in case different versions of the same distribution need to be built during the resolution process. Using the TMPDIR/TEMP/TMP environment variable, possibly combined with --no-clean covers known use cases. (`8372 <https://github.com/pypa/pip/issues/8372>`_) - Remove undocumented and deprecated option ``--always-unzip`` (`8408 <https://github.com/pypa/pip/issues/8408>`_) Features -------- - Log debugging information about pip, in ``pip install --verbose``. (`3166 <https://github.com/pypa/pip/issues/3166>`_) - Refine error messages to avoid showing Python tracebacks when an HTTP error occurs. (`5380 <https://github.com/pypa/pip/issues/5380>`_) - Install wheel files directly instead of extracting them to a temp directory. (`6030 <https://github.com/pypa/pip/issues/6030>`_) - Add a beta version of pip's next-generation dependency resolver. Move pip's new resolver into beta, remove the ``--unstable-feature=resolver`` flag, and enable the ``--use-feature=2020-resolver`` flag. The new resolver is significantly stricter and more consistent when it receives incompatible instructions, and reduces support for certain kinds of :ref:`Constraints Files`, so some workarounds and workflows may break. More details about how to test and migrate, and how to report issues, at :ref:`Resolver changes 2020` . Maintainers are preparing to ``` ### 20.2b1 ``` =================== Bug Fixes --------- - Correctly treat wheels containing non-ASCII file contents so they can be installed on Windows. (`5712 <https://github.com/pypa/pip/issues/5712>`_) - Prompt the user for password if the keyring backend doesn't return one (`7998 <https://github.com/pypa/pip/issues/7998>`_) Improved Documentation ---------------------- - Add GitHub issue template for reporting when the dependency resolver fails (`8207 <https://github.com/pypa/pip/issues/8207>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pip - Changelog: https://pyup.io/changelogs/pip/ - Homepage: https://pip.pypa.io/ </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

153: Update pip to 20.2 r=duckinator a=pyup-bot This PR updates [pip](https://pypi.org/project/pip) from **20.1.1** to **20.2**. <details> <summary>Changelog</summary> ### 20.2 ``` ================= Deprecations and Removals ------------------------- - Deprecate setup.py-based builds that do not generate an ``.egg-info`` directory. (`6998 <https://github.com/pypa/pip/issues/6998>`_, `8617 <https://github.com/pypa/pip/issues/8617>`_) - Disallow passing install-location-related arguments in ``--install-options``. (`7309 <https://github.com/pypa/pip/issues/7309>`_) - Add deprecation warning for invalid requirements format "base>=1.0[extra]" (`8288 <https://github.com/pypa/pip/issues/8288>`_) - Deprecate legacy setup.py install when building a wheel failed for source distributions without pyproject.toml (`8368 <https://github.com/pypa/pip/issues/8368>`_) - Deprecate -b/--build/--build-dir/--build-directory. Its current behaviour is confusing and breaks in case different versions of the same distribution need to be built during the resolution process. Using the TMPDIR/TEMP/TMP environment variable, possibly combined with --no-clean covers known use cases. (`8372 <https://github.com/pypa/pip/issues/8372>`_) - Remove undocumented and deprecated option ``--always-unzip`` (`8408 <https://github.com/pypa/pip/issues/8408>`_) Features -------- - Log debugging information about pip, in ``pip install --verbose``. (`3166 <https://github.com/pypa/pip/issues/3166>`_) - Refine error messages to avoid showing Python tracebacks when an HTTP error occurs. (`5380 <https://github.com/pypa/pip/issues/5380>`_) - Install wheel files directly instead of extracting them to a temp directory. (`6030 <https://github.com/pypa/pip/issues/6030>`_) - Add a beta version of pip's next-generation dependency resolver. Move pip's new resolver into beta, remove the ``--unstable-feature=resolver`` flag, and enable the ``--use-feature=2020-resolver`` flag. The new resolver is significantly stricter and more consistent when it receives incompatible instructions, and reduces support for certain kinds of :ref:`Constraints Files`, so some workarounds and workflows may break. More details about how to test and migrate, and how to report issues, at :ref:`Resolver changes 2020` . Maintainers are preparing to ``` ### 20.2b1 ``` =================== Bug Fixes --------- - Correctly treat wheels containing non-ASCII file contents so they can be installed on Windows. (`5712 <https://github.com/pypa/pip/issues/5712>`_) - Prompt the user for password if the keyring backend doesn't return one (`7998 <https://github.com/pypa/pip/issues/7998>`_) Improved Documentation ---------------------- - Add GitHub issue template for reporting when the dependency resolver fails (`8207 <https://github.com/pypa/pip/issues/8207>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pip - Changelog: https://pyup.io/changelogs/pip/ - Homepage: https://pip.pypa.io/ </details> Co-authored-by: pyup-bot <github-bot@pyup.io> Co-authored-by: Ellen Marie Dash <me@duckie.co>

triage-new-issues bot added the S: needs triage Issues/PRs that need to be triaged label Sep 9, 2019

chrahunt added kind: backwards incompatible Would be backward incompatible project: setuptools Related to setuptools state: needs discussion This needs some more discussion labels Sep 9, 2019

triage-new-issues bot removed S: needs triage Issues/PRs that need to be triaged labels Sep 9, 2019

chrahunt mentioned this issue Sep 9, 2019

Remove FIXME from InstallRequirement.install #7000

Merged

chrahunt mentioned this issue Nov 6, 2019

Deprecate setup.py-based builds that do not make .egg-info #7305

Merged

chrahunt added the type: deprecation Related to deprecation / removal. label Nov 6, 2019

chrahunt removed the state: needs discussion This needs some more discussion label Nov 6, 2019

tushar2708 mentioned this issue Jan 29, 2020

ImportError: cannot import name 'KiteConnect' zerodha/pykiteconnect#70

Closed

joeirimpan added a commit to joeirimpan/pykiteconnect that referenced this issue Feb 7, 2020

fix: Use setuptools egg install runner

6de5449

* pypa/pip#6998 Do not assume egg install for all setuptools version

joeirimpan mentioned this issue Feb 7, 2020

fix: Use setuptools egg install runner zerodha/pykiteconnect#71

Merged

hdiogenes mentioned this issue Feb 7, 2020

.egg-info deprecation warning from pip>=20.0 kytos/kytos#1036

Closed

sbidoul added this to the 20.2 milestone May 24, 2020

pradyunsg added the !release blocker Hold a release until this is resolved label Jul 2, 2020

This was referenced Jul 17, 2020

pip 20.2 release (Q3 2020) #8511

Closed

Reject setup.py projects that don't generate .egg-info #8617

Merged

pradyunsg closed this as completed in #8617 Jul 24, 2020

github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fail legacy install if .egg-info directory was not created #6998

Fail legacy install if .egg-info directory was not created #6998

chrahunt commented Sep 9, 2019 •

edited

Loading

pradyunsg commented Nov 6, 2019

sbidoul commented May 24, 2020

pradyunsg commented Jul 2, 2020

Fail legacy install if .egg-info directory was not created #6998

Fail legacy install if .egg-info directory was not created #6998

Comments

chrahunt commented Sep 9, 2019 • edited Loading

pradyunsg commented Nov 6, 2019

sbidoul commented May 24, 2020

pradyunsg commented Jul 2, 2020

chrahunt commented Sep 9, 2019 •

edited

Loading