-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add triage notes about redistributors #10914
Conversation
👍 for the Debian and Ubuntu wording. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradyunsg, the text looks like Markdown, but it should be ReStructuredText 😄. Excluding that, I give this PR a +1.
The Markdown is in a code block that’s supposed to be copied into a GitHub issue. So the syntax is correct here, I think. |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Markdown is in a code block that’s supposed to be copied into a GitHub issue. So the syntax is correct here, I think.
If so, we can merge this now :)
The
rst-backticks
check needs be made smarter to ignore single ticks in a code block.
I'll send an issue to pre-commit/pygrep-hooks
.
See pre-commit/pygrep-hooks#95. Thinking a bit more about this, can |
Or we can just use double backticks in Markdown 😉 Markdown is permissive regarding inline code, it works as long as the opening and ending numbers match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we can just use double backticks in Markdown 😉 Markdown is permissive regarding inline code, it works as long as the opening and ending numbers match.
@pradyunsg Can we try this to avoid CI failures in future PRs?
This avoids the weird linter issues we're having here.
a65164b
to
79ef8f3
Compare
I've done this. I wanna move the entire documentation to Markdown wherever possible anyway. :) |
Merging this, since I imagine this is fairly non-controversial. If there's concerns on this, holler here! :) |
x-ref: #9677