Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dependency chain on each Collecting line #11169

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

iXce
Copy link
Contributor

@iXce iXce commented Jun 6, 2022

This tremendously helps understand why a package is being fetched and
can help investigate and fix dependency resolver backtracking issues
when incoherent constraints/package sets are provided or when new
versions of a package trigger a completely different backtracking
strategy, leading to very hard to debug situations.

@uranusjr
Copy link
Member

Can you add a test for this?

@iXce iXce force-pushed the display_collection_comes_from branch from ebc103b to 1fe1099 Compare August 16, 2022 02:46
@pypa-bot
Copy link

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@pypa-bot pypa-bot added the needs rebase or merge PR has conflicts with current master label Aug 16, 2022
@iXce iXce force-pushed the display_collection_comes_from branch from 1fe1099 to 525cd1a Compare August 16, 2022 02:47
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Aug 16, 2022
@iXce
Copy link
Contributor Author

iXce commented Aug 16, 2022

Can you add a test for this?

Done! I haven't been sure how to add reviewers explicitly to the PR (I assumed I'd need a well documented issue to back the PR and haven't taken the time to do so)

@iXce iXce force-pushed the display_collection_comes_from branch 4 times, most recently from 330d749 to ccaf0c4 Compare August 16, 2022 16:58
@iXce
Copy link
Contributor Author

iXce commented Aug 16, 2022

Hm that remaining PR failure seems to be spurious? 🤔

@uranusjr
Copy link
Member

Yes, seems unrelated.

@iXce
Copy link
Contributor Author

iXce commented Aug 16, 2022

Is there a way to jog the CI to rerun the failed checks?

@uranusjr
Copy link
Member

Not needed, we can merge it either way.

@iXce iXce force-pushed the display_collection_comes_from branch from ccaf0c4 to f034b7e Compare August 31, 2022 16:46
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a meaningful news fragment. This is a feature, not trivial.

@iXce iXce requested a review from uranusjr September 8, 2022 03:54
@iXce iXce force-pushed the display_collection_comes_from branch from f034b7e to 92918f9 Compare September 8, 2022 03:54
@iXce
Copy link
Contributor Author

iXce commented Sep 8, 2022

What about this?

@iXce
Copy link
Contributor Author

iXce commented Sep 27, 2022

Is there something else needed to get this merged? (I cannot add other reviewers it seems, if that's what's needed)

This tremendously helps understand why a package is being fetched and
can help investigate and fix dependency resolver backtracking issues
when incoherent constraints/package sets are provided or when new
versions of a package trigger a completely different backtracking
strategy, leading to very hard to debug situations.
@iXce iXce force-pushed the display_collection_comes_from branch from 92918f9 to c546c99 Compare February 24, 2023 02:12
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 24, 2023
@iXce
Copy link
Contributor Author

iXce commented Feb 24, 2023

rebased to the latest :) @uranusjr anything I should do to get this merged? I encounter needs for this almost on a daily basis (a very good example is the ongoing sklearn package sunsetting strategy ; knowing which trail of dependencies pulls in sklearn from the install logs would be super useful to fix the requirements)

@pradyunsg pradyunsg merged commit 61e85bf into pypa:main Feb 24, 2023
@pradyunsg
Copy link
Member

This will make it harder for me to clean up some stuff later, but we'll cross that bridge when we get there. Thanks @iXce for the PR!

@iXce
Copy link
Contributor Author

iXce commented Feb 24, 2023

Thanks @pradyunsg !

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants