Make keyring integration opt-in (closes #8719, #6773) #11215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aba9e96.
SnoopJ
force-pushed
the
feature/opt-in-keyring
branch
from
45f2aeb
to
ec0348d
Compare
github-actions
bot
added
the
needs rebase or merge
|
Changes from #11589 are now incorporated, there were some relatively small conflicts but nothing too bad. I didn't note this before, but the main change of this PR is to make This is once again ready for review |
|
CI failure is not related to this changeset, see #11643 |
|
See recent discussions in #8719 (comment) |
Merged
|
Closing in favor of #11698 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--enable-keyringflag to requirement commands, as laid out in #8719. This also implicitly fixes #6773 and possibly some related issues by makingkeyringan opt-in feature.I've tested this locally (including environment variable and config file specification) by sticking breakpoints around the retrieval of credentials from the keyring, and it seems to be right. I haven't added any test here because 1) the existing tests are kind of abstract, and 2) I'm not sure if the internal plumbing is quite right anyway. Happy to make changes as desired by the maintainers.