Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to illustrate the whole path towards disentangling
--no-binary
. Please do not do detailed code review here, it will be split in individual PRs for review. Questions and suggestions on the overall approach are most welcome here.This is encapsulates my takeaways from #9778 and #9422.
deprecate
--install-option
(Deprecate --install-options #11359)clarify the warning message when
--install-option/--global-option/--build-option
is used, saying that it implies--no-binary=:all:
which is accurate, instead ofdisabling all use of wheel
which was not entirely true in all cases. (also in Deprecate --install-options #11359)add a dreprecation warning when
--no-binary
implies setup.py installadd a
no-binary-builds-wheels
feature flag which does the following when--no-binary
is used:setup.py install
let it build and install a wheel (thereby silencing the deprecation warning)pip install
andpip wheel
(the user can still control it with--no-cache
)pass
--build-option
and--global-option
in the build step, likepip wheel
does - if only for symmetry and to soften the transition; we nevertheless recommend users to use--config-settings
and we'll likely deprecate these in the future, forpip install
andpip wheel
at the same time.