Prevent pkg_resource access on Python 3.12+ #11661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Dec 16, 2022
1 task
Time is up. If a downstream Python distributor hasn't implemented importlib.metadata support by now, they must expect things to break.
uranusjr
force-pushed
the
no-pkg-resources-3.12
branch
2 times, most recently
from
5805d83
to
0ee7f85
Compare
This customization is generally provided by the distributor, and the user can do nothing if the environment is configured incorrectly. So instead of breaking pip entirely, we silently ignore the customization and let the distributor correct the situation.
uranusjr
force-pushed
the
no-pkg-resources-3.12
branch
from
0ee7f85
to
7cfc915
Compare
1 task
|
Don’t need this anymore since setuptools fixed this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time is up. If a downstream Python distributor hasn't implemented importlib.metadata support by now, they must expect things to break.
Close #11501.