Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyring multi choice #11698

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Keyring multi choice #11698

merged 7 commits into from
Mar 15, 2023

Commits on Jan 30, 2023

  1. Make it possible to request a keyring provider: auto, disabled, `…

    …import` or `subprocess`
    
    Refactored `_get_index_url()` to get integration tests for the subprocess backend working.
    
    Keyring support via the 'subprocess' provider can only retrieve a password, not a username-password combo. The username therefor MUST come from the URL.
    If the URL obtained from the index does not contain a username then the username from a matching index is used. `_get_index_url()` does that matching.
    
    The problem this refactoring solves is that the URL where a wheel or sdist can be downloaded from does not always start with the index url. Azure DevOps Artifacts Feeds are an example since it replaces the friendly name of the Feed with the GUID of the Feed. Causing `url.startswith(prefix)` to evaluate as `False`.
    
    The new behaviour is to return the index which matches the netloc and has the longest common prefix of the `path` property of the value returned by `urllib.parse.urlsplit()`. The behaviour for resolving ties is unspecified.
    Dos Moonen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    33cd541 View commit details
    Browse the repository at this point in the history
  2. Revise documentation on keyring

    uranusjr authored and Dos Moonen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    0a9ff9d View commit details
    Browse the repository at this point in the history
  3. Better subprocess handling

    uranusjr authored and Dos Moonen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    d325245 View commit details
    Browse the repository at this point in the history
  4. Typo in documentation: s/if/is

    Dos Moonen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7b75fda View commit details
    Browse the repository at this point in the history
  5. Applied review suggestions

    Dos Moonen committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    16bd6b7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a840f1d View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Merge branch 'main' into keyring-multi-choice

    # Conflicts:
    #	src/pip/_internal/network/auth.py
    Dos Moonen committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    6affad8 View commit details
    Browse the repository at this point in the history