Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .git-blame-ignore-revs for Black reformatting commits #12045

Merged
merged 2 commits into from
May 21, 2023

Conversation

pradyunsg
Copy link
Member

These commits make git blame slightly more difficult to navigate, and it is now possible to ignore them on GitHub automatically (and git, with the right configuration). See https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view for the feature documentation.

I got the commit list with the following, and cleaned it up manually.

for repo in 8903 8906 9757 10191 10192 10193 10196 10274 10360
do
 gh api /repos/pypa/pip/pulls/$repo/commits | jq '.[] | "\(.sha)  # \(.commit.message)"'
done

These commits make git blame slightly more difficult to navigate, and
it is now possible to ignore them on GitHub.
@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label May 21, 2023
@pradyunsg
Copy link
Member Author

https://akrabat.com/ignoring-revisions-with-git-blame/ has more details on how/why this is useful.

This file doesn't affect how the build-system behaves and
isn't for distribution.
Copy link
Member

@sbidoul sbidoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 although I have not verified each commit in the list :)

@pradyunsg pradyunsg merged commit 3aaf5c3 into pypa:main May 21, 2023
@pradyunsg pradyunsg deleted the ignore-revs branch May 21, 2023 23:40
@pradyunsg
Copy link
Member Author

We can tweak the list in the future, if the need arises. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants