Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build using build #12355

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Build using build #12355

merged 1 commit into from
Oct 18, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 15, 2023

Update the build-release nox session to build using build instead of a direct setup.py call.

Update the build-release nox session to build using `build`
instead of a direct setup.py call.
@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Oct 15, 2023
noxfile.py Show resolved Hide resolved
@pradyunsg
Copy link
Member

Huh, the last time I tried this, it failed because build's isolation was broken. I guess it's a good thing that they fixed this at some point. :)

@sbidoul
Copy link
Member Author

sbidoul commented Oct 15, 2023

It works fine and I checked it gives the same result for 23.3.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 18, 2023

I merge this so I'll eat my own dog food when doing the patch release.

@sbidoul sbidoul merged commit 8a0f77c into pypa:main Oct 18, 2023
24 of 25 checks passed
@sbidoul sbidoul deleted the build-using-build branch October 18, 2023 08:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants