Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check both index URL and its hostname for keyring entries #8635

Closed
wants to merge 2 commits into from

Conversation

EpicWink
Copy link
Contributor

Fixes #8634

@pfmoore
Copy link
Member

pfmoore commented Jul 27, 2020

This sounds more like a bug with the SecretService backend. I'd rather that gets fixed, than we carry a workaround for their issue.

What does the keyring spec for backends say in this regard?

@EpicWink
Copy link
Contributor Author

EpicWink commented Jul 27, 2020

Keyring says to check out keyring.backend for the full details. This says nothing on what to do if no entries exist in the documentation, but the default implementation clearly requires a username and password.

Unfortunately, the SecretService back-end has fancy logic to search through items if the username is not provided, so I think this is best a question for @jaraco

@jaraco
Copy link
Member

jaraco commented Jul 28, 2020

I agree with Paul. Keyring should provide a reliable interface.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 4, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 8, 2021
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Aug 15, 2021
@pradyunsg
Copy link
Member

Closing this out, since this is significantly out of date.

If there's still interest in doing this, I encourage the interested folks to file a new PR for this. :)

@pradyunsg pradyunsg closed this Sep 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs rebase or merge PR has conflicts with current master
Projects
None yet
6 participants