Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace a better error message on installation failure due to invalid .data files in wheels #8656

Merged
merged 3 commits into from
Aug 2, 2020

Commits on Jul 29, 2020

  1. Explicitly handle incorrect .data paths during wheel install

    Previously our wheel installation process allowed wheels which contained
    non-conforming contents in a contained .data directory.
    
    After the refactoring to enable direct-from-wheel installation, pip
    throws an exception when encountering these wheels, but does not include
    any helpful information to pinpoint the cause.
    
    Now if we encounter such a wheel, we trace an error that includes the
    name of the requirement we're trying to install, the path to the wheel
    file, the path we didn't understand, and a hint about what we expect.
    chrahunt committed Jul 29, 2020
    Configuration menu
    Copy the full SHA
    864f0e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2020

  1. Provide a reasonable error on invalid scheme keys

    Originally we would throw an `AttributeError` if a bad scheme key was
    used. After refactoring we would throw a `KeyError`, which isn't much
    better. Now we call out the wheel being processed, scheme key we didn't
    recognize, and provide a list of the valid scheme keys. This would
    likely be useful for people developing/testing the wheel.
    chrahunt committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    3f9b326 View commit details
    Browse the repository at this point in the history
  2. Add news

    chrahunt committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    127c5b0 View commit details
    Browse the repository at this point in the history