Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize name in check_if_exists #8659

Merged
merged 1 commit into from
Aug 2, 2020
Merged

Canonicalize name in check_if_exists #8659

merged 1 commit into from
Aug 2, 2020

Commits on Jul 30, 2020

  1. Canonicalize name in check_if_exists 

    The previous implementation uses pkg_resources.get_distribution(), which
does not canonicalize the package name correctly, and fails when
combined with pip's own get_distribution(), which does canonicalize
names. This makes InstallRequirement.check_if_exists() only use pip's
own canonicalization logic so different package name forms are matched
as expected.
    @uranusjr
    uranusjr committed Jul 30, 2020
    Configuration menu
    Copy the full SHA
    1fd5098 View commit details
    Browse the repository at this point in the history