Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resolver constraint markers #8727

Merged
merged 2 commits into from
Aug 7, 2020

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Aug 7, 2020

Fix #8724. That’s easier than I expected 🙂

@uranusjr uranusjr added this to the 20.2.2 milestone Aug 7, 2020
@uranusjr uranusjr requested a review from pfmoore August 7, 2020 05:55
@uranusjr uranusjr force-pushed the new-resolver-constraint-markers branch from b277846 to 4683ad0 Compare August 7, 2020 05:55
@pradyunsg
Copy link
Member

CI ain't happy.

@pfmoore
Copy link
Member

pfmoore commented Aug 7, 2020

LGTM, but CI needs fixing. Ping me to review when the CI is working, and I'll approve then (just in case fixing the CI adds extra complexity...).

@uranusjr uranusjr closed this Aug 7, 2020
@uranusjr
Copy link
Member Author

uranusjr commented Aug 7, 2020

Looks like PyPI had some availability issues. Rerunning.

@uranusjr uranusjr reopened this Aug 7, 2020
@pradyunsg pradyunsg merged commit d6d84e7 into pypa:master Aug 7, 2020
@pradyunsg
Copy link
Member

Merged since Paul already OK'ed this change, and no additional changes were made. :)

@uranusjr uranusjr deleted the new-resolver-constraint-markers branch August 7, 2020 09:34
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Aug 11, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2020-resolver] Fails if two versions with ; python_version in constraints for the same package
3 participants