-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipenv no longer working under the root directory is not listed as a breaking change #4273
Comments
hi @gps035, I'm having the same issue with pipenv. Thanks |
I can confirm that this behaviour does not happen on version @mohamedMok You can use |
I have filed a PR to address this issue, thanks for everyone. |
Not a funny breaking changes, all our dockers are using pipenv install during build :/ |
Run into the same issue, using fix in #4273 (comment) worked for me. |
can you explain the workflow here -- are you using |
As I just mentioned in #4275:
This is not intended to be a breaking change, it's intended to prevent a previously broken interaction -- for anyone for whom this was working, please include the full set of command line arguments you were passing to pipenv (e.g.
Thats probably enough for now |
@techalchemy This is the relevant portions of our Dockerfile which no longer works.
|
@techalchemy Thanks for canvassing use cases. Here's another example:
In case it's useful for investigation or reproducing the issue, the build steps are visible in this Make target. |
For anyone who wants to use the latest pipenv with
|
FROM python:3-slim AS base
ENV PYROOT /pyroot
ENV PYTHONUSERBASE $PYROOT
ENV PATH $PATH:$PYROOT/bin
FROM base AS builder
RUN pip install pipenv
COPY Pipfile* ./
RUN PIP_USER=1 PIP_IGNORE_INSTALLED=1 pipenv install --system --deploy --ignore-pipfile |
This worked for me. Just remember to create the |
the WORKDIR command already creates the directory if it does not exist |
Using
when using dockerfile below FROM python:3-slim AS base
ENV PYROOT /pyroot
ENV PYTHONUSERBASE $PYROOT
ENV PATH $PATH:$PYROOT/bin
FROM base AS builder
WORKDIR /build
RUN pip install pipenv
COPY Pipfile* /build/
RUN PIP_USER=1 PIP_IGNORE_INSTALLED=1 pipenv install --system --deploy --ignore-pipfile |
this does not seem to actually be build error, see #4220 |
As a sidenote, Also, the In any case @killuazhu the error in the logs you included are possibly related to the manipulations of your python path, but will require further investigation if you can file a separate issue |
For reference, the original issue of #3434 occurs when one tries to |
Thank you for fixing, do you have an ETA on when the fix will be included in a new release of the pypi package? |
we need to ensure all regression issues are fixed and the new release will be out in the next week |
Awesome thank you, appreciate it! |
I was getting a slightly different error when running
Pinning to the old version also worked for me. Thanks! |
I’m having the same issue. Now pinning to the old version as a workaround |
This issue is still present in the 2020.6.2 release: Output: Could you please confirm if this issue was expected to be fixed in 2020.6.2 release? |
I can confirm I'm hitting this issue with the following
|
@frostming Can you please reopen the issue? |
I can also confirm I'm hitting this issue with the following Dockerfile:
Here is the error:
|
For folks still having this issue the easiest fix is to configure your Dockerfile as:
|
This bug manifested slightly differently for me, but #4273 (comment) solved it nonetheless.
|
Issue description
Our docker builds failed this morning due to a change in behaviour when running
pipenv install
in the root directory.When running with the latest version (2020.5.28) an error is thrown after dependencies are built and installed
ERROR: Pipenv is not intended to work under the root directory, please choose another path.
It looks like this is a change introduced in #3386, relating to an issue raised in #3434.
This issue is really just to point out that this behaviour change should be listed as breaking in the changelog, as it doesn't currently appear to be mentioned.
For the time being we have worked around this by pinning
pipenv
to the last version (2018.11.26).Expected result
N/A
Actual result
N/A
Steps to replicate
N/A
The text was updated successfully, but these errors were encountered: