Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for recently introduced regressions #5011

Closed
matteius opened this issue Mar 26, 2022 · 1 comment
Closed

Add unit tests for recently introduced regressions #5011

matteius opened this issue Mar 26, 2022 · 1 comment
Assignees
Labels
Category: Tests Relates to tests. PR: merged The PR related to this issue has been merged.

Comments

@matteius
Copy link
Member

This ticket is to add tests for some of the recent regressions and feature changes:

  • pipenv run pip freeze should have predictable and clean stdout logging
  • pipenv run script --quiet should still load .env vars (and not log the message about it)
  • Bonus would be: a test for the package index restriction. This might be hard because we only have a single pypi server running, but I was thinking about an example that relies on pulling from our named pypi server when pypi.org is avialable and a newer package version exists there, so that might be a feasible test to add.
@matteius matteius added the Category: Tests Relates to tests. label Mar 26, 2022
@matteius matteius self-assigned this Mar 26, 2022
This was referenced Mar 26, 2022
@matteius
Copy link
Member Author

Fixed with: #5017

@matteius matteius added the PR: merged The PR related to this issue has been merged. label Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tests Relates to tests. PR: merged The PR related to this issue has been merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant