Subdirectory vcs installs are never passing the subdirectory in requirementslib which is now required by setuptools #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteius
commented
Mar 28, 2022
| @@ -210,27 +210,6 @@ def test_scripts(PipenvInstance): | |||
| assert 'which python' in c.stdout | |||
|
|
|||
|
|
|||
| @pytest.mark.cli | |||
| def test_scripts_resolve_dot_env_vars(PipenvInstance): | |||
There was a problem hiding this comment.
I wrote this test recently but technically put it in the wrong file -- relocated it in this PR and extended it's use case.
matteius
changed the title
frostming
approved these changes
Mar 28, 2022
|
Thanks @frostming, I have now access to requirementslib but unfortunately the build of main is already failing there by the time I have seen the project, so it will take me more time to patch upstream. Its on my list since I already have another PR over there for the future pip vendoring as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would appear that potentially a recent change to setuptools revealed that we weren't actually passing in the subdirectory properly to generate the pep517 wheels, and that was revealed ~3 days ago when the CI started failing on a change that was merged in but had passed the CI the day before.
Fixes #5019
Fixes #5014