-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python_full_version vs python_version #5499
Comments
here's another report about output not being consistent, i.e |
Tried repeatedly with 2022.11.23 version, and can not reproduce. i guess it's gotten better with newer releases?
ps: why is |
Yeah, there was a bug with that hacktoberfest PR that was corrected shortly after. |
@matteius can you find the PR (or PRs) and refer it (them) here, or at least what version is needed? |
and what is the final outcome that needs to be I still get changes like these: - "markers": "python_version >= '3.6'",
+ "markers": "python_full_version >= '3.6.0'", + "exceptiongroup": {
+ "hashes": [
+ "sha256:542adf9dea4055530d6e1279602fa5cb11dab2395fa650b8674eaec35fc4a828",
+ "sha256:bd14967b79cd9bdb54d97323216f8fdf533e278df937aa2a90089e7d6e06e5ec"
+ ],
+ "markers": "python_version < '3.11'",
+ "version": "==1.0.4"
+ }, why is that dependency added/removed? |
@glensc -- It seems that the new version of requests-cache has an indirect dependency on |
@glensc Your pipenv support output shows you are on |
I figured I had |
but anyway, with 2023.11.23 I get this outcome and there's still both in the output: |
Just that |
looks like problem is hit again, and it removed the "exceptiongroup" dependency. why? because dependabot runs older version? |
okay, but how did 3.6 become 3.6.0 if package version is still same, i.e "2.1.1": and similarly where did |
And also, version marker being replaced with "index": "pypi" is same bug or a new bug? |
Hey, I can still reproduce this behavior.
|
@koleror dependabot is still using old pipenv I believe. |
Sad but ok 👌 |
@koleror there have been recent efforts to upgrade dependabot's version of pipenv -- I am not sure where they are at with it currently, but it would be worth checking around their PR/s and backlog, here is a starting point: dependabot/dependabot-core#7922 |
dependabot/dependabot-core#7922 is merged now |
Issue description
Do you know why pipenv generates extra diffs changing
python_version
topython_full_version
and vice versa? And seemingly unrelated package updates.At first I thought it was due to mixing
pipenv
versions, and created bug report to dependabot:but now created 3 commits sequentially with same version and the
python_version
was changed topython_full_version
in one commit andpython_full_version
topython_version
in another commit.Branch:
pipenv uninstall requests-cache
): glensc/PlexTraktSync@287fc25pipenv install requests-cache
): glensc/PlexTraktSync@f766896pipenv install requests-cache==0.9.7
): glensc/PlexTraktSync@da587c0So, I noticed:
python_version
topython_full_version
forcharset-normalizer
python_version
was changed topython_full_version
forpfzy
,pygments
packagespfzy
packageThe test is ran with version that dependabot suppsedly runs (
pipenv==2022.4.8
):but it has happened with newer versions too.
Expected result
Consistent, Pipfile.lock, is it
python_full_version
orpython_version
doesn't matter as long it sticks to one variant.sometimes it changes python_version < '4' to python_version < '4.0', drops python_version >= '3.6':
Actual result
When possible, provide the verbose output (
--verbose
), especially for locking and dependencies resolving issues.Steps to replicate
$ pipenv --support
Pipenv version:
'2022.4.8'
Python installations found:
PEP 508 Information:
System environment variables:
SHELL
Pipenv–specific environment variables:
PIPENV_VERBOSITY
:-1
Debug–specific environment variables:
SHELL
:/usr/local/bin/bash
EDITOR
:/usr/local/bin/nvim
LANG
:en_US.UTF-8
Contents of
Pipfile
('/Users/glen/MegaSync/scm/plex/PlexTraktSync/Pipfile'):Contents of
Pipfile.lock
('/Users/glen/MegaSync/scm/plex/PlexTraktSync/Pipfile.lock'):The text was updated successfully, but these errors were encountered: