-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python full version in pipfile #5387
Conversation
expected output doesn't match current output which is "python_version": "3.10"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR.
Please fix the linting issue, and add a news fragment.
This is then good to be merged!
thanks @oz123 ! we should be good to go now 😎 |
Please rename the news snippet to: 5345.behavior.rst |
As I suspected this change leads to breakage of CI.
I think that pinning to a minor version is not a good thing. Unless it's additional. What I mean is, we should have both, e.g.:
|
and news segment
f4472d2
to
5bf9f1b
Compare
@oz123 I updated it so now the pipfile will record both the python version and the full version in addition if specified. Also updated tests so should work for whatever python version the test is running. Sorry for the back and forth and hopefully we good to go now 🤞 |
OK. Already very promising. Just add some more explanation to the news file, and we are good to go. |
What happens if a new minor version is released? Will users have to manually update the |
Thank you for contributing to Pipenv!
The issue
#5345
A user requested that when the full version is specified that it gets added to a new pipfile when it is created so that he/she wouldn't need to manually add it themselves.
The fix
Found the spot where the pipefile [requires] section gets created and modified it slightly to save based on if full version was specified or not.
The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.