Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont ignore compatibility check #2065

Closed
wants to merge 1 commit into from

Conversation

frostming
Copy link
Contributor

_link_package_versions is only called by _package_versions. I guess it's safe to modify the default value here.

Fixes #1901

@techalchemy
Copy link
Member

This is not an acceptable fix.

We ignore compatibility to allow the resolution of cross platform wheels. We have already modified this, setting it to True.

@techalchemy
Copy link
Member

Btw @frostming if you want to look further at this there is some difference between ipython and most other packages. This works fine most of the time but we need to make the pip-tools resolver or this introspect python_requires inside the wheel — I think pip-tools is a better target but I’m not 100% sure. I just don’t want to lose all of the extra functionally

@frostming
Copy link
Contributor Author

@techalchemy I understand that changing the flag will affect things more than python_requires check.

What about doing a filter against candidates in piptools's Resolver WRT python_requires only?

@techalchemy
Copy link
Member

@frostming I was just looking at this, doing some testing around that now but I'd love to have this with just the related tests that fail (if i can fix it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants