test: update html attribute order #235
Conversation
|
Well, this is now fun. 😁 Since bleach 5.x dropped support for Python 3.6, the older 4.x version is installed, and fails the tests. Question: When do we feel comfortable dropping support for Python 3.6 testing (or even listed in the classifiers)? |
I'm fine with dropping support now, Python 3.6 is EOL. |
miketheman
force-pushed
the
miketheman/ci-fails-for-order-of-234
branch
from
8bc927c
to
adaadc3
Compare
|
@miketheman Would you mind dropping support in a separate PR? |
No problem, will move that commit (and a couple others) to a different PR, and get that done before this one. |
With bleach 5.0.0, attribute order has changed to be preserved from the origin, rather than alphabetized for consistency. These tests failed due to the output change. Closes: pypa#234 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/ci-fails-for-order-of-234
branch
from
adaadc3
to
790b423
Compare
|
@di our powers combined, I think we did it! |
|
Thank you @miketheman! One last thing, would you like to create a PR to bump for release? |
|
Sure thing - coming right up! |
With bleach 5.0.0, attribute order has changed to be preserved from the
origin, rather than alphabetized for consistency.
These tests failed due to the output change.
Closes: #234
Signed-off-by: Mike Fiedler miketheman@gmail.com