Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds testing for 3.12, fixes #290 #300

Merged
merged 2 commits into from
Feb 13, 2024
Merged

adds testing for 3.12, fixes #290 #300

merged 2 commits into from
Feb 13, 2024

Conversation

mistwire
Copy link
Contributor

fixes #290

miketheman
miketheman previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thanks!

@miketheman
Copy link
Member

One last request: please add an entry for 3.12 in pyproject.toml

@mistwire mistwire requested a review from miketheman February 13, 2024 16:01
miketheman
miketheman approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@miketheman miketheman merged commit 78ccf3f into pypa:main Feb 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miketheman miketheman miketheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test against Python 3.12
2 participants
@mistwire @miketheman