Warn about markdown content type when checking RST #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging so I can prepare a release, but happy to address any concerns post-hoc before merging the actual release. |
di
reviewed
Apr 10, 2018
| @@ -26,6 +28,16 @@ def check_restructuredtext(self): | |||
| Checks if the long string fields are reST-compliant. | |||
| """ | |||
| data = self.distribution.get_long_description() | |||
| content_type = getattr( | |||
| self.distribution.metadata, 'long_description_content_type', None) | |||
There was a problem hiding this comment.
I'm not sure when self.distribution.metadata came to be -- is this available in all version of distutils? Otherwise we might want to test whether these attributes exist.
There was a problem hiding this comment.
That's probably far enough 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81 and consequently #63.