Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate examples to src-layout #25

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Migrate examples to src-layout #25

merged 5 commits into from
Apr 19, 2024

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented Nov 29, 2023

This pull requests transfers the src-layout into a separate branch - this will need to be merged with the main branch regularly, preserving the layout-related changes. We'll still have to add a note to the README on master.

When this is approved, I'll also create a legacy table.

Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Thank you very much, @chrysle

@webknjaz
Copy link
Member

webknjaz commented Feb 3, 2024

@chrysle I have an advice for maintaining PR branches — always use forks, even if you have full upstream access. To arbitrary users, the branch list like https://github.com/pypa/sample-namespace-packages/branches/all is confusing. Moreover, when contributors fork the repo, they may get copies of those branches at the moment of forking but won't get branch updates as they are modified upstream or cleaned up, effectively leaving them with non-collected garbage in their forks.

@chrysle
Copy link
Contributor Author

chrysle commented Feb 3, 2024

Thanks for the advice, I'll stick to this in the future (only I would have to close this because GH doesn't allow for changing PR branches, AFAIK). BTW, could you re-visit the neighbouring PR?

@webknjaz
Copy link
Member

webknjaz commented Feb 3, 2024

@chrysle yeah, no need to close. Just keep in mind for the future.

@chrysle
Copy link
Contributor Author

chrysle commented Apr 18, 2024

@abravalheri FYI added a .gitattributes file to handle merge conflicts with the new branch. The legacy table now isn't correct for this branch, should I remove it or re-run the scenarios?

@abravalheri
Copy link
Contributor

abravalheri commented Apr 18, 2024

Hi @chrysle, the presence of the legacy table is something that depends on the README.

Previously, we had:

If you would like to know about deprecated installation methods (e.g. via python setup.py install) or Python 2.7, please have a look at legacy_table.md.

As a nod to the historical data in the repo (e.g. maybe there is a link somewhere referencing this repo and talking about the differences between 2.7 and 3) so that we don't remove historical data and keep consistency with old references.

If that is something you removed, it might be fine to remove the file in the branch, too.

Or update the link to reference a different branch

@chrysle
Copy link
Contributor Author

chrysle commented Apr 18, 2024

Or update the link to reference a different branch

Done!

@chrysle chrysle merged commit 4f1c4b1 into src-layout Apr 19, 2024
0 of 6 checks passed
@chrysle chrysle deleted the chrysle/src-layout branch April 19, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants