Preserve encoding with edit_config #1729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsadok
force-pushed
the
preserve_encoding
branch
from
7401ecd to
a812b37
Compare
|
Wrapped io.open with try-catch IOError, to better match the behavior of |
PR pypa#1180 and 24be5ab changed the way we read setup.cfg, but when editing setup.cfg we might still lose the encoding hint on the file, which can cause failures in subsequent steps. This change detectes the encoding like in `_parse_config_files` and writes an encoding hint header if the file encoding was detected. Fixes jaraco/configparser#37.
itsadok
force-pushed
the
preserve_encoding
branch
from
a812b37 to
06c89b5
Compare
|
See #1702, where I'm proposing a somewhat different approach. Instead of investing more heavily in encoding declarations on a file, I'd rather standardize on UTF-8 as the sole encoding for the file. |
|
OK, yeah. My code doesn't work, as I couldn't find a way to make Python 2.7's ConfigParser write UTF-8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1180 and 24be5ab changed the way we read setup.cfg, but when
editing setup.cfg we might still lose the encoding hint on the file,
which can cause failures in subsequent steps.
This change detectes the encoding like in
_parse_config_filesandwrites an encoding hint header if the file encoding was detected.
Fixes jaraco/configparser#37.