Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage config update for protocols #4464

Closed
wants to merge 3 commits into from
Closed

Test coverage config update for protocols #4464

wants to merge 3 commits into from

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Jul 9, 2024 •
edited
Loading

Just a test to confirm whether

  1. Single-line elipsis bodies are automatically excluded from coverage (making @overload redundant)
  2. Excluding Protocols would resolve failing coverage for Initial pyright config #4192

If this works like I think it would, I'll PR to the skeleton.

@Avasam Avasam mentioned this pull request Jul 9, 2024
Merged
2 tasks
@Avasam Avasam mentioned this pull request Jul 20, 2024
Merged
@Avasam
Copy link
Contributor Author

Avasam commented Jul 30, 2024 •
edited
Loading

Results of this test are satisfactory and a PR has been opened upstream : jaraco/skeleton#135

@Avasam Avasam closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Avasam