Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge distutils fix for setting Py_GIL_DISABLED on Windows #4761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lysnikolaou
Copy link

Summary of changes

Related to #4662 and pypa/distutils#310.

Pull Request Checklist

@Avasam
Copy link
Contributor

Avasam commented Nov 30, 2024

Wouldn't this be automatically included with the next distutils sync ?
https://setuptools.pypa.io/en/latest/development/developer-guide.html#code-conventions-and-other-practices

the setuptools/_distutils directory [...] should not be modified directly when contributing to the setuptools project. Instead, this directory is maintained as a separated project [...], and periodically merged into setuptools.

@lysnikolaou
Copy link
Author

Oh, I missed that part of the contributing guide.

Let me know if I can help out somehow in doing that. I can probably pull in all the other changes in the distutils repo if necessary. Otherwise, let's close this PR.

@MatthieuDartiailh
Copy link

@Avasam do you know when the sync will happen ? I am waiting on this fix to publish a new release of https://github.com/nucleic/kiwi.

@Avasam
Copy link
Contributor

Avasam commented Dec 14, 2024

@Avasam do you know when the sync will happen ? I am waiting on this fix to publish a new release of nucleic/kiwi.

That's a question for @jaraco , I am not a maintainer here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants