Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

231 address first mypy errors #359

Closed
wants to merge 5 commits into from
Closed

231 address first mypy errors #359

wants to merge 5 commits into from

Commits on May 14, 2018

  1. (231) Add mypy checks to CI, change lint python to 3.6 

    * Rename the pep8 tox environment to lint and add mypy
* Use basepython 3.6 since mypy requires >= 3.4
* Update twine/utils.py so flake8/python 3.6 passes

Paired with Tathagata Dasgupta.
    @fhocutt
    fhocutt committed May 14, 2018
    Configuration menu
    Copy the full SHA
    3db1889 View commit details
    Browse the repository at this point in the history

  2. Don't run flake8 on docs

    @fhocutt
    fhocutt committed May 14, 2018
    Configuration menu
    Copy the full SHA
    c36164b View commit details
    Browse the repository at this point in the history

  3. Run mypy but ignore failure for now

    @fhocutt
    fhocutt committed May 14, 2018
    Configuration menu
    Copy the full SHA
    5488731 View commit details
    Browse the repository at this point in the history

  4. Change py27 TOXENV to new lint env

    @fhocutt
    fhocutt committed May 14, 2018
    Configuration menu
    Copy the full SHA
    43e430e View commit details
    Browse the repository at this point in the history

  5. (231) Address initial mypy errors 

    Ignore errors on conditional imports (open mypy bug), explicitly pass
None to upload.main(), put mypy back into CI.
    @fhocutt
    fhocutt committed May 14, 2018
    Configuration menu
    Copy the full SHA
    204b38e View commit details
    Browse the repository at this point in the history