Fixes Travis build failure - Mypy #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename the pep8 tox environment to lint and add mypy * Use basepython 3.6 since mypy requires >= 3.4 * Update twine/utils.py so flake8/python 3.6 passes Paired with Tathagata Dasgupta.
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
=======================================
Coverage 74.06% 74.06%
=======================================
Files 13 13
Lines 667 667
Branches 99 99
=======================================
Hits 494 494
Misses 145 145
Partials 28 28
Continue to review full report at Codecov.
|
|
@sigmavirus24 @theacodes Could you please review this? Thanks |
|
Perfect @waseem18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #357
PR #357 was failing because in
.travis.ymlthelintjob inmatrix / includehas the Python version 2.7. Changing the Python version to 3.6 resolves the issue.@fhocutt Thanks for your work on this.