-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: mypy support #466
WIP: mypy support #466
Conversation
@carljm is there some kind of "hey mypy experts! help?" bat-signal I can shine? If so, help me shine it? :-) |
@brainwane I commented on #231 with some thoughts about overall approach to typing in twine. As for bat signal, a lot of Python typing experts hang out in https://gitter.im/python/typing -- you could ask specific questions there for sure, you could also post a link to this PR and see if anyone is interested in reviewing it. |
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=========================================
- Coverage 82.93% 82.73% -0.2%
=========================================
Files 14 14
Lines 750 753 +3
Branches 108 108
=========================================
+ Hits 622 623 +1
- Misses 92 94 +2
Partials 36 36
Continue to review full report at Codecov.
|
Note: there's an alternate approach in #469, leveraging MonkeyType. |
Related to #231, building on #344.
I'm a newbie to mypy, but at @brainwane's suggestion, I decided to dive in as an exercise. I've skimmed the Zulip blog (which is somewhat outdated, e.g. CLI options and broken links), read mypy's getting started and existing codebase docs, and reviewed the existing PR's.
I got
lint-mypy
to pass in 8f569a5 (covering some of the ground from #359), then addedcheck_untyped_defs
as suggested by Zulip. I know the preference is to use stub files, but the initial batch of errors seemed to require local variable annotations. I'd love some feedback on this direction.Current errors: