Sort imports based on flake8-import-order #572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| import keyring | ||
|
|
||
| from . import utils | ||
| from . import exceptions |
There was a problem hiding this comment.
We seem to have a mixture of absolute imports from twine import ... and absolute-relative imports from . import ... we should probably standardize on those
There was a problem hiding this comment.
Happy to address this after we settle on one of these PRs.
jaraco
approved these changes
Feb 12, 2020
|
Superseded by #570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to #570, and partially out of my own curiosity. I think I prefer isort, but I don't feel strongly.
Changes:
tox -e lint-code-stylezimports --multi-importsto format importsAs in the other PR, this allows multiple imports per line, which minimizes the changes, esp. with the
typingmodule.