Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging environment #1616

Closed
wants to merge 1 commit into from
Closed

Conversation

ssbarnea
Copy link
Contributor

Adds a packaging environment and documents its use. This should clarify how
to build and install and unreleased version.

Related: #1609

Adds a packaging environment and documents its use. This should clarify how
to build and install and unreleased version.

Related: pypa#1609
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not adding this part was very much conscious decision. The reason I did not add this upfront is that I'm not sure I want to support this. Why not use the sdist/wheel? I'd prefer not to support building from git 🤷‍♂

Going ahead I'd prefer we discuss such proposals before we create PRs.

@ssbarnea
Copy link
Contributor Author

@gaborbernat If you do not want to advertise the pip+git install approach is ok, but in that case we should at least add some fail-safe code inside setup.py to make it fail quickly when run with outdated pip. Better to fail-fast when we know there is no chance of success instead of receiving bug reports from confused users.

@ssbarnea
Copy link
Contributor Author

@gaborbernat can I find you on freenode? my nick is zbr. I am in both #pypa-dev and #pypa channels all the time.

@gaborbernat
Copy link
Contributor

Gitter? I don't follow freenode 🤷‍♂

@gaborbernat
Copy link
Contributor

but in that case we should at least add some fail-safe code inside setup.py to make it fail quickly when run with outdated pip.

I'm on board with that; added #1621

@gaborbernat
Copy link
Contributor

We now have 👍 for a chat-like interface, https://gitter.im/pypa/virtualenv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants